fix(material/testing): Fix minor issue preventing the label filter from working for some implementations
#31596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildcardalice
requested review from
mmalerba and
andrewseguin
and removed request for
a team
mmalerba
approved these changes
Jul 24, 2025
mmalerba
added
action: merge
wildcardalice
force-pushed
the
label-filter-dev
branch
4 times, most recently
from
750bea9 to
4d00a37
Compare
a label, including fallback functionality that checks `mat-label`
wildcardalice
force-pushed
the
label-filter-dev
branch
from
4d00a37 to
d6cbbcf
Compare
|
The changes were merged into the following branches: main, 20.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the FormFieldControlHarness label capabilities to support a wider range of implementations. This affects any harness that derives from MatFormFieldControlHarnessBase, such as MatInputHarness and MatSelectHarness.
The current implementation works as expected when searching for a floating mat-label within a mat-form-field. However, it fails when searching for a label that is provided via
<label for=...>oraria-label, as are suggested in the Material documentation. This change aims to expand support for these patterns to match the supporting documentation.